Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter system messages from missed message notifications #955

Merged
merged 3 commits into from
Jan 23, 2024
Merged

fix: filter system messages from missed message notifications #955

merged 3 commits into from
Jan 23, 2024

Conversation

LomyW
Copy link
Contributor

@LomyW LomyW commented Jan 18, 2024 •
edited
Loading

Description

✅ What was done

  • add filter for system messages

⚗️ Tests

  • Tests local with webhook

Checklist before requesting a review

  • I have performed a self-review of my code

@LomyW LomyW self-assigned this Jan 18, 2024
@realmayus realmayus temporarily deployed to backend-feat-1092-no-sy-nv2tda January 18, 2024 14:25 Inactive
@LomyW LomyW requested a review from dhenkel92 January 18, 2024 14:40
@LomyW LomyW changed the title fix: filter out system messages from missed message notifications fix: filter system messages from missed message notifications Jan 19, 2024
LucasFalkowsky
LucasFalkowsky previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@LucasFalkowsky LucasFalkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complexity overflow

Well done!

@realmayus realmayus temporarily deployed to backend-feat-1092-no-sy-nv2tda January 22, 2024 13:36 Inactive
@LomyW LomyW requested a review from LucasFalkowsky January 22, 2024 14:14
@realmayus realmayus temporarily deployed to backend-feat-1092-no-sy-nv2tda January 22, 2024 14:14 Inactive
@LomyW LomyW merged commit b5a7fec into master Jan 23, 2024
2 checks passed
@LomyW LomyW deleted the feat/1092-no-system-message-notification branch January 23, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhenkel92 dhenkel92 dhenkel92 approved these changes

@LucasFalkowsky LucasFalkowsky Awaiting requested review from LucasFalkowsky

Assignees

@LomyW LomyW

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LomyW @dhenkel92 @LucasFalkowsky @realmayus